Wireshark · Wireshark-commits: [Wireshark-commits] master 4349961: Qt: Move Signals/Slots to subclass

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=434996197247af81b278a7a135195d72c091d56b
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4349961 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Move Signals/Slots to subclass
    
    Signals/Slots should be initialized by the utilizing class not
    the parent class. That way the utilizing class can be changed
    without interfering with the parent
    
    Change-Id: I5d538b4c487d3092f0f76bc2b54bc63fbc3ba547
    Reviewed-on: https://code.wireshark.org/review/35015
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  1b151d8   Qt: Fix order of contextmenu for DisplayFilter
     add  4349961   Qt: Move Signals/Slots to subclass


Summary of changes:
 ui/qt/main_window.cpp                 |  7 -------
 ui/qt/widgets/display_filter_edit.cpp | 18 ++++++++++++++++++
 ui/qt/widgets/display_filter_edit.h   |  2 ++
 3 files changed, 20 insertions(+), 7 deletions(-)