Wireshark-commits: [Wireshark-commits] master 88306c2: Qt: fix compilation with older versions.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 06 Nov 2019 13:38:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=88306c251abe99f8255dbf858eb3c8058e52eb84
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

88306c2 by Dario Lombardo (lomato@xxxxxxxxx):

    Qt: fix compilation with older versions.
    
    Fix travis linux builds.
    
    ../ui/qt/widgets/display_filter_edit.cpp:130:56: error: no matching function for call to ‘QAction::QAction(QString)’
         QAction * na = new QAction(tr("Left align buttons"));
                                                            ^
    In file included from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qactiongroup.h:37,
                     from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QActionGroup:1,
                     from ../ui/qt/widgets/display_filter_edit.h:14,
                     from ../ui/qt/widgets/display_filter_edit.cpp:20:
    /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qaction.h:174:5: note: candidate: ‘QAction::QAction(QActionPrivate&, QObject*)’
         QAction(QActionPrivate &dd, QObject *parent);
         ^~~~~~~
    
    Change-Id: I03be478bc17296cc6adca6df82cdd41bcc0504b4
    Reviewed-on: https://code.wireshark.org/review/34995
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  1178c59   BGP EVPN: Adding Type 10 route support
     add  88306c2   Qt: fix compilation with older versions.


Summary of changes:
 ui/qt/widgets/display_filter_edit.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)