Wireshark-commits: [Wireshark-commits] master 2ecb282: dot11decrypt: Let dissector feed engine with
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 04 Nov 2019 17:54:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ecb2828a8763b895d729c4816d46183398471d8
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2ecb282 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    dot11decrypt: Let dissector feed engine with EAPOL key message type
    
    EAPOL key message type is known by dissector so no need for dot11decrypt
    to parse frames to determine this. Instead feed engine with message
    type from dissector. With this some code duplication can be avoided.
    
    Change-Id: Icfd119186ebab5b0db29968df3eb94275d921e76
    Reviewed-on: https://code.wireshark.org/review/34929
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  0ec8bd5   dot11decrypt: Separate key extraction step from decryption step
     add  2ecb282   dot11decrypt: Let dissector feed engine with EAPOL key message type


Summary of changes:
 epan/crypt/dot11decrypt.c          | 270 +++++++++++++++++--------------------
 epan/crypt/dot11decrypt_system.h   |  12 ++
 epan/dissectors/packet-ieee80211.c |  21 +--
 3 files changed, 150 insertions(+), 153 deletions(-)