Wireshark-commits: [Wireshark-commits] master eeb179e: snort: fix non-static 'g_file_separator' var
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 03 Nov 2019 17:20:30 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eeb179edee3ee7e640909df28565ca5a14e0d3b1
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

eeb179e by Peter Wu (peter@xxxxxxxxxxxxx):

    snort: fix non-static 'g_file_separator' variable
    
    Clang warned (-Wmissing-variable-declarations) about a non-static
    'g_file_separator' variable. Remove it since the G_DIR_SEPARATOR_S macro
    fulfills the same purpose, and use g_build_path since it is more
    appropriate and does not have length limits.
    
    Change-Id: I696c82a6ce3f58e6a28b87f096f1f7bf7ae73cf7
    Reviewed-on: https://code.wireshark.org/review/34925
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  59e669e   Qt: Fix Filter drag and drop
     add  eeb179e   snort: fix non-static 'g_file_separator' variable


Summary of changes:
 epan/dissectors/snort-config.c | 30 ++++++++++++------------------
 1 file changed, 12 insertions(+), 18 deletions(-)