Wireshark-commits: [Wireshark-commits] master dc0445c: s7comm: Add read record function
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 02 Nov 2019 16:56:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dc0445c2922631570469c2cfe571fde75e7f29ce
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

dc0445c by Thomas Wiens (th.wiens@xxxxxx):

    s7comm: Add read record function
    
    Added a new function code for reading a data record. The function
    parameters are similar to the RDREC call from the s7 plc. It allows to
    read diagnostic information from a module by it's diagnostic address.
    
    Change-Id: If041ed016928136eee75e1154cd87cee27cfd869
    Reviewed-on: https://code.wireshark.org/review/34902
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  9fce1ba   filter_list_model (Qt): Fix Dead Store
     add  dc0445c   s7comm: Add read record function


Summary of changes:
 epan/dissectors/packet-s7comm.c | 185 ++++++++++++++++++++++++++++++++++------
 1 file changed, 157 insertions(+), 28 deletions(-)