Wireshark-commits: [Wireshark-commits] master eb4e83d: asn2wrs.py: fix parsing of integer unions wi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Oct 2019 20:16:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eb4e83d5891165ca1f958cf57641200a8cb5a0b4
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

eb4e83d by Pascal Quantin (pascal@xxxxxxxxxxxxx):

    asn2wrs.py: fix parsing of integer unions with extension
    
    When parsing the description
    ExpectedActivityPeriod ::= INTEGER (1..30|40|50|60|80|100|120|150|180|181,...)
    asn2wrs.py was generating some code where the has_extension flag was
    wrongly set to false, leading to a decoding error.
    
    Bug: 16145
    Change-Id: I0d54994c0656f5b48f3dcd1864218c45a4ebc308
    Reviewed-on: https://code.wireshark.org/review/34837
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  e50fd8b   NAS 5GS: small fixes for PDU session establishment request message
     add  eb4e83d   asn2wrs.py: fix parsing of integer unions with extension


Summary of changes:
 epan/dissectors/packet-ngap.c | 4 ++--
 epan/dissectors/packet-s1ap.c | 4 ++--
 epan/dissectors/packet-x2ap.c | 4 ++--
 epan/dissectors/packet-xnap.c | 4 ++--
 tools/asn2wrs.py              | 2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)