Wireshark-commits: [Wireshark-commits] master 6820e35: Qt: Fix Column Preferences
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 20 Oct 2019 22:20:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6820e3515aded1768f6885e2cb9349ba8b8e9118
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6820e35 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Fix Column Preferences
    
    The current implementation has some serious bugs. e.g. if an added
    column is moved, existing columns disappear. Also, if new columns
    are being added, existing columns may disappear. This moves the column
    preferences to a Movel/View concept and implements necessary checks
    to ensure, that such an issue cannot occur
    
    Change-Id: I73810812180e2fbed4d2fe67316f190aba82c719
    Reviewed-on: https://code.wireshark.org/review/34819
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  df1c73d   Opcua: Fix display of GUIDs
     add  6820e35   Qt: Fix Column Preferences


Summary of changes:
 ui/qt/CMakeLists.txt               |   2 +
 ui/qt/column_preferences_frame.cpp | 379 +++---------------------------
 ui/qt/column_preferences_frame.h   |  25 +-
 ui/qt/column_preferences_frame.ui  |  44 ++--
 ui/qt/models/column_list_model.cpp | 458 +++++++++++++++++++++++++++++++++++++
 ui/qt/models/column_list_model.h   |  91 ++++++++
 6 files changed, 604 insertions(+), 395 deletions(-)
 create mode 100644 ui/qt/models/column_list_model.cpp
 create mode 100644 ui/qt/models/column_list_model.h