Wireshark-commits: [Wireshark-commits] master-3.0 4f1a07c: Increase maximum USBPcap packet size to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 18 Oct 2019 05:01:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4f1a07c93cc7fd468f7b1cc2c60cb76eda5bb0f4
Submitter: "Tomasz Moń <desowin@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

4f1a07c by Tomasz Moń (desowin@xxxxxxxxx):

    Increase maximum USBPcap packet size to 128 MiB
    
    It turned out that 1 MiB is not enough as atleast the URBs sent by
    Android fastbool tools are greater than 1 MiB (1 MiB payload + USBPcap
    pseudoheader). Raise the maximum packet size all the way up to 128 MiB.
    128 MiB is the upper bound of maximum packet that can be captured by
    all official USBPcap releases.
    
    Bug: 15985
    Change-Id: Ibbf41f7efae6e0f841e36d39664394e8a8eae77d
    Reviewed-on: https://code.wireshark.org/review/34793
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit c869b567df19dff24e4ad9ffef59dd0f7c543241)
    Reviewed-on: https://code.wireshark.org/review/34801
    Reviewed-by: Tomasz Moń <desowin@xxxxxxxxx>
    

Actions performed:

    from  3a938a3   IP: Make dissection of ip.frag_offset RFC 791 compliant
     add  4f1a07c   Increase maximum USBPcap packet size to 128 MiB


Summary of changes:
 wiretap/wtap.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)