Wireshark-commits: [Wireshark-commits] master fd56ad3: Wi-Fi NAN: Fix rval_to_channel_set reading p
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 17 Oct 2019 16:00:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd56ad3326e6746082ef3c8d234393f1935ad897
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

fd56ad3 by Connor Newton (c.newton@xxxxxxxxxxx):

    Wi-Fi NAN: Fix rval_to_channel_set reading past end of op_class_ch...
    
    Looks like I broke it by fixing it...
    
    Added the table terminator again.
    
    The real solution to this when there is time is to use the 802.11
    dissector for operating classes, as this is a duplicate and not
    fantastically thought out implementation.
    
    Bug: 16123
    Change-Id: Ide7071b71825b1595e14a474bcb0c57ee8eb0bf5
    Reviewed-on: https://code.wireshark.org/review/34792
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  32d1d96   androiddump: Fix tcpdump encap type signed/unsigned conversion error
     add  fd56ad3   Wi-Fi NAN: Fix rval_to_channel_set reading past end of op_class_ch...


Summary of changes:
 epan/dissectors/packet-wifi-nan.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)