Wireshark · Wireshark-commits: [Wireshark-commits] master 6210195: Protobuf: Add show_details preferences. Fix two bugs.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62101950f3be2c54f06d4a3e138c4b0000a4f58a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6210195 by Huang Qiangxiong (qiangxiong.huang@xxxxxx):

    Protobuf: Add show_details preferences. Fix two bugs.
    
    1. Add show_details preferences. Disable it will hidden names of
    message/field/enum, field number, and other details.
    
    2. Have only one popup message with all the errors listed,
    that are found during parsing .proto files. (Buffer errors and print once)
    Loading .proto files and checking message types of UDP port will
    be done only when protobuf dissector has been called.
    
    3. Support parsing .proto files in legacy MAC file format
    (that newline is '\r') or mixed newline (\r + \n) file format.
    
    Change-Id: I97bcde000957e4cd1cce98a7f61120d03027423e
    Reviewed-on: https://code.wireshark.org/review/34736
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c797e94   Qt: Fix export dissection dialog
     add  6210195   Protobuf: Add show_details preferences. Fix two bugs.


Summary of changes:
 debian/libwireshark0.symbols      |   1 +
 epan/dissectors/packet-protobuf.c | 194 ++++++++++++++++++++++++++++----------
 epan/protobuf_lang.y              |   2 +-
 epan/protobuf_lang_scanner.l      |   4 +-
 epan/protobuf_lang_tree.c         |   2 +-
 epan/protobuf_lang_tree.h         |   2 +-
 epan/wmem/wmem_strbuf.c           |   4 +-
 epan/wmem/wmem_strbuf.h           |   4 +
 8 files changed, 155 insertions(+), 58 deletions(-)