Wireshark-commits: [Wireshark-commits] master 9ffe5f6: GPRS RLC/MAC: clarify defcription of hf_glob
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 05 Oct 2019 10:50:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9ffe5f61e92e49833c256d47a7db5a4e09e6e002
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9ffe5f6 by Vadim Yanitskiy (axilirator@xxxxxxxxx):

    GPRS RLC/MAC: clarify defcription of hf_global_tfi
    
    According to 3GPP TS 44.060, section 12.10 "Global TFI", the first
    bit of that IE defines whether it's an Uplink (0) or Downlink (1)
    TFI (Temporary Flow Identity).
    
    Before this patch:
    
      Global_TFI
          .1.. .... = UL TFI:  (Union)
          ..01 110. = DL TFI: 14
    
    After:
    
      Global_TFI
          .1.. .... = Uplink (0) or Downlink (1) TFI:  (Union)
          ..01 110. = DL TFI: 14
    
    Change-Id: Idcf25b007bce8ee065fd10753dbd3292ab0ce95e
    Reviewed-on: https://code.wireshark.org/review/34713
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a1b16a4   GSM RLC/MAC: distinguish TA Index / TS number for Uplink and Downlink
     add  9ffe5f6   GPRS RLC/MAC: clarify defcription of hf_global_tfi


Summary of changes:
 epan/dissectors/packet-gsm_rlcmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)