Wireshark-commits: [Wireshark-commits] master 13a9a98: dtn: Updates to TCPCL and AMP parsers and dt
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 04 Oct 2019 13:10:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=13a9a98f956fd2b37e90e3fff29d1118a88f0aff
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

13a9a98 by Keith Scott (keithlscott@xxxxxxxxx):

    dtn: Updates to TCPCL and AMP parsers and dtn payload ids.
    
    This patch updates the TCP Convergence Layer (TCPCL) parser, updates the
    Compressed Bundle Header Encoding (CBHE) BP Endpoints that identify
    CCSDS File Delivery Protocol (CFDP) and Asynchronous Management Protocol
    (AMP) payloads, and adds an AMP dissector that parses the new Compressed
    Bundle Header Encoding (CBOR) wire format.
    
    1. Correctly parses the TCP Convergence Layer Length field
    2. Adds support for the TCP Convergence Layer Refuse-Bundle Reason-Code
       Flags per RFC-7242: Section-5.4
    3. Parses BP traffic between Compressed Bundle Header Encoding (CBHE)
       endpoints 64 and 65 as CCSDS File Delivery Protocol (CFDP)
       payloads.
    4. Parses BP traffic beetween Compressed Bundle Header Encoding (CBHE)
       endpoints 5 and 6 as Asynchronous Network Management (AMP)
       payloads
    5. Updates the AMP parser to use the new Compressed Binary Object
       Representation (CBOR)
    
    The AMP dissector was originally written by Krishnamurthy Mayya
    (krishnamurthymayya@xxxxxxxxx) against an older version of the AMP
    specification and updated to parse the new Compressed Binary Object
    Representation (CBOR) format by Keith Scott (keithlscott@xxxxxxxxx)
    
    Change-Id: I8d1eff9fb09f1a9dbdb9f4cf077448316f6a9e05
    Reviewed-on: https://code.wireshark.org/review/34216
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ba88d0a   F1AP: upgrade dissector to v15.7.0
     add  13a9a98   dtn: Updates to TCPCL and AMP parsers and dtn payload ids.


Summary of changes:
 epan/dissectors/CMakeLists.txt |   1 +
 epan/dissectors/packet-amp.c   | 845 +++++++++++++++++++++++++++++++++++++++++
 epan/dissectors/packet-cfdp.c  | 573 ++++++++++++++++++++++------
 epan/dissectors/packet-dtn.c   |  68 +++-
 epan/dissectors/packet-dtn.h   |   9 +
 5 files changed, 1383 insertions(+), 113 deletions(-)
 create mode 100644 epan/dissectors/packet-amp.c