Wireshark-commits: [Wireshark-commits] master e768e13: Qt: Fix Follow Stream regression in Conversa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 30 Sep 2019 05:45:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e768e13479796dba755884941d210153b9823986
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e768e13 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: Fix Follow Stream regression in Conversations dialog
    
    The "Follow Stream" button did not have any effect due to:
    
        QObject::connect: No such slot MainWindow::openFollowStreamDialog(follow_type_t, guint) in /tmp/wireshark/ui/qt/main_window_slots.cpp:3034
        QObject::connect:  (sender name:   'TrafficTableDialog')
        QObject::connect:  (receiver name: 'MainWindow')
    
    Change-Id: If9ecae9a971bdc31358d95af33a8245aa5df5911
    Fixes: v3.1.1rc0-352-g9fff62e2a8 ("Qt, http2: Add Follow HTTP/2 Stream functionality")
    Reviewed-on: https://code.wireshark.org/review/34653
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jim Young <jim.young.ws@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  486c6fd   Fix interpretation of BSO field in Type III headers.
     add  e768e13   Qt: Fix Follow Stream regression in Conversations dialog


Summary of changes:
 ui/qt/conversation_dialog.cpp | 3 ++-
 ui/qt/conversation_dialog.h   | 2 +-
 ui/qt/main_window_slots.cpp   | 4 ++--
 3 files changed, 5 insertions(+), 4 deletions(-)