Wireshark-commits: [Wireshark-commits] master-3.0 062e4ff: Improve the handling of the FT (Frame Ty
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 29 Sep 2019 23:13:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=062e4ff67fcf5047429988ac49f17cd89196fe71
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

062e4ff by Guy Harris (guy@xxxxxxxxxxxx):

    Improve the handling of the FT (Frame Type) field in Type III headers.
    
    Show the value symbolically, and don't dissect the payload as an
    Ethernet packet if the value isn't 0, meaning "Ethernet".
    
    This gets rid of the mis-dissection of the payload in the capture
    atttached to bug 16089, although it doesn't dissect it any further, as
    we don't know how to dissect it.
    
    Change-Id: I97fce0f7a4f4336339bc90271aa7b19c97831abe
    Ping-Bug: 16089
    Reviewed-on: https://code.wireshark.org/review/34649
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 3f73bff64f66e4849c871330a7bd3bd57d756779)
    Reviewed-on: https://code.wireshark.org/review/34650
    

Actions performed:

    from  c0fa96f   [Automatic update for 2019-09-29]
     add  062e4ff   Improve the handling of the FT (Frame Type) field in Type III headers.


Summary of changes:
 epan/dissectors/packet-cisco-erspan.c | 32 ++++++++++++++++++++++++++------
 1 file changed, 26 insertions(+), 6 deletions(-)