Wireshark-commits: [Wireshark-commits] master 66ad175: wsutil: Use file descriptor in file_needs_re
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Sep 2019 20:54:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=66ad175c47ae8c251a036e735546c3024fb34144
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

66ad175 by Tomasz Moń (desowin@xxxxxxxxx):

    wsutil: Use file descriptor in file_needs_reopen()
    
    There's no extra benefit in having FILE pointer (over file descriptor)
    passed to file_needs_reopen().
    
    Change-Id: Id49eb2f02b776c2f1ccd9d67fedd7eac38432f52
    Reviewed-on: https://code.wireshark.org/review/34600
    Reviewed-by: Craig Jackson <cejackson51@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7d36ae9   NAS 5GS: fix dissection of Mapped EPS bearer contexts IE
     add  66ad175   wsutil: Use file descriptor in file_needs_reopen()


Summary of changes:
 epan/dissectors/packet-tls-utils.c | 4 ++--
 epan/dissectors/packet-wireguard.c | 4 ++--
 wsutil/filesystem.c                | 6 +++---
 wsutil/filesystem.h                | 3 +--
 4 files changed, 8 insertions(+), 9 deletions(-)