Wireshark-commits: [Wireshark-commits] master bd439c9: Win32: Do not reload TLS keylog file on each
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bd439c909045de71f3ab6907ff3f2e74682e7f3a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
bd439c9 by Tomasz Moń (desowin@xxxxxxxxx):
Win32: Do not reload TLS keylog file on each packet
On Windows, fstat() and stat() sets st_dev to different value depending
on whether it was called with file handle or file path. If file handle
was used, the st_dev is simply the file handle casted to unsigned.
If file path was used, then st_dev corresponds to drive letter
(A=0, B=1, C=2, ...).
Compare the files using the file index information retrieved by
GetFileInformationByHandle(). When compiled in configuration that
supports FILE_ID_INFO, the code first tries to obtain 128-bit FILE_ID_INFO
and if that fails, fallback to GetFileInformationByHandle().
Bug: 16059
Change-Id: I5f8d8d8127337891ef9907c291e550b1d17aabbb
Reviewed-on: https://code.wireshark.org/review/34573
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 001de56 http2: show a clear warning when Wireshark lacks nghttp2
add bd439c9 Win32: Do not reload TLS keylog file on each packet
Summary of changes:
debian/libwsutil0.symbols | 1 +
epan/dissectors/packet-tls-utils.c | 20 ------------
epan/dissectors/packet-wireguard.c | 22 +------------
wsutil/filesystem.c | 65 ++++++++++++++++++++++++++++++++++++++
wsutil/filesystem.h | 6 ++++
5 files changed, 73 insertions(+), 41 deletions(-)