Wireshark-commits: [Wireshark-commits] master b43177e: Qt: Fix invalid pointer for model
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 Sep 2019 15:00:27 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b43177e1f0603cb08f5e422e0a52a67d30f42d83
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b43177e by Roland Knall (rknall@xxxxxxxxx):

    Qt: Fix invalid pointer for model
    
    Ideally it should never happen, that the model is being queried
    outside it's scope, which is ONLY the PacketList. MainWindow is
    the last place where such queries should happen. In the meantime
    a check for invalid model is being added.
    
    Bug: 16065
    Change-Id: I9a3fa39333d55dbbb7ebcac87f39da7bd8547486
    Reviewed-on: https://code.wireshark.org/review/34591
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  7d874e2   RRC: do not use a freed wmem_strbuf structure
     add  b43177e   Qt: Fix invalid pointer for model


Summary of changes:
 ui/qt/main_window_slots.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)