Wireshark-commits: [Wireshark-commits] master 828ff6d: Qt: Fix issues found by clang.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Sep 2019 19:24:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=828ff6ddb0a824de7f48af8b2018c3d4506a48ce
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

828ff6d by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    Qt: Fix issues found by clang.
    
    Fix the following issues:
    
    ../ui/qt/rtp_player_dialog.cpp:88:21: error: unused variable 'wf_graph_selected_width_' [-Werror,-Wunused-const-variable]
    static const double wf_graph_selected_width_ = 2.0;
                        ^
    
     In file included from /home/vasko/sources/wireshark/ui/qt/sequence_diagram.cpp:10:
    /home/vasko/sources/wireshark/ui/qt/sequence_diagram.h:59:20: error: 'selectTest' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        virtual double selectTest(const QPointF &pos, bool onlySelectable, QVariant *details=0) const;
                       ^
    /home/vasko/sources/wireshark/ui/qt/widgets/qcustomplot.h:3330:18: note: overridden virtual function is here
    /home/vasko/sources/wireshark/ui/qt/tcp_stream_dialog.cpp:60:12: error: unused variable 'graph_color_4' [-Werror,-Wunused-const-variable]
    const QRgb graph_color_4 = tango_scarlet_red_4;
               ^
    /home/vasko/sources/wireshark/ui/qt/tcp_stream_dialog.cpp:61:12: error: unused variable 'graph_color_5' [-Werror,-Wunused-const-variable]
    const QRgb graph_color_5 = tango_scarlet_red_6;
               ^
    
    Change-Id: Ic0d96939cc13fc550aa6857ddc75fe498e7104ea
    Reviewed-on: https://code.wireshark.org/review/34555
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Vasil Velichkov <vvvelichkov@xxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  3d8fe9a   extcap: Fix type in example
     add  828ff6d   Qt: Fix issues found by clang.


Summary of changes:
 ui/qt/rtp_player_dialog.cpp | 1 -
 ui/qt/sequence_diagram.h    | 2 +-
 ui/qt/tcp_stream_dialog.cpp | 2 ++
 3 files changed, 3 insertions(+), 2 deletions(-)