Wireshark-commits: [Wireshark-commits] master-3.0 347d3c9: Remove the UTF-8 validation from proto_t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 09 Sep 2019 20:14:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=347d3c9d9e6b4a237da16f6eb56ca7e81a4568a8
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

347d3c9 by Guy Harris (guy@xxxxxxxxxxxx):

    Remove the UTF-8 validation from proto_tree_add_string().
    
    proto_tree_add_item() does no validation if ENC_UTF_8 is used as the
    encoding, so there's no guarantee that the value of a string field is
    valid UTF-8, and in some dissectors UTF-8 strings are fetched with other
    mechanisms and then added with proto_tree_add_string().
    
    We need to do some cleanup on string handling.
    
    Bug: 15848
    Change-Id: Ifc43111dbb47c478fa11280f2f771d90202499fa
    Reviewed-on: https://code.wireshark.org/review/33677
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 088b3d63a00d57183a24805a6bf7390f8136352b)
    Reviewed-on: https://code.wireshark.org/review/34488
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  d956535   Qt UI: Warn about not saving non-PCM encoded audio
     add  347d3c9   Remove the UTF-8 validation from proto_tree_add_string().


Summary of changes:
 epan/proto.c | 4 ----
 1 file changed, 4 deletions(-)