Wireshark-commits: [Wireshark-commits] master-3.0 d956535: Qt UI: Warn about not saving non-PCM enc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 08 Sep 2019 12:45:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d9565354555d9c9798ca32e9a2c11d224b1128ab
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

d956535 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Qt UI: Warn about not saving non-PCM encoded audio
    
    When saving audio data from RTP stream(s) in Sun AU format we (still) do
    not harness the build-in codec framework. This results in empty Audio
    files for all but PCM encoded RTP streams. At least warn the user about
    the codec not being supported for saving in Audio file.
    
    Change-Id: Ia76caf71d0d5319a66dbf1cee517c0922bf7a561
    Reviewed-on: https://code.wireshark.org/review/34466
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit bc1c3dc9a0d27722bab62a1f1f96c764764524ae)
    Reviewed-on: https://code.wireshark.org/review/34474
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  34f4096   Qt UI: remove empty jitter buffer label tooltip
     add  d956535   Qt UI: Warn about not saving non-PCM encoded audio


Summary of changes:
 ui/qt/rtp_analysis_dialog.cpp | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)