Wireshark-commits: [Wireshark-commits] master bc1c3dc: Qt UI: Warn about not saving non-PCM encoded
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 08 Sep 2019 06:13:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bc1c3dc9a0d27722bab62a1f1f96c764764524ae
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

bc1c3dc by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Qt UI: Warn about not saving non-PCM encoded audio
    
    When saving audio data from RTP stream(s) in Sun AU format we (still) do
    not harness the build-in codec framework. This results in empty Audio
    files for all but PCM encoded RTP streams. At least warn the user about
    the codec not being supported for saving in Audio file.
    
    Change-Id: Ia76caf71d0d5319a66dbf1cee517c0922bf7a561
    Reviewed-on: https://code.wireshark.org/review/34466
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a585a65   Qt UI: remove empty jitter buffer label tooltip
     add  bc1c3dc   Qt UI: Warn about not saving non-PCM encoded audio


Summary of changes:
 ui/qt/rtp_analysis_dialog.cpp | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)