Wireshark-commits: [Wireshark-commits] master f2162a1: Qt: fix compilation for enabled_protocols_mo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 04 Sep 2019 11:44:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f2162a1005328a4921367cc52b767f7629944330
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f2162a1 by Dario Lombardo (lomato@xxxxxxxxx):

    Qt: fix compilation for enabled_protocols_model.
    
    clang complains, gcc doesn't.
    
    Error:
    In file included from ../ui/qt/enabled_protocols_dialog.cpp:10:
    In file included from ../ui/qt/enabled_protocols_dialog.h:15:
    ../ui/qt/models/enabled_protocols_model.h:121:18: error: 'filterAcceptsRow' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        virtual bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const;
    
    Change-Id: Ifbba736158a841752da27349925a3b55556728ca
    Reviewed-on: https://code.wireshark.org/review/34447
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  f0c0e1c   Qt: Fix override declarations for PacketList
     add  f2162a1   Qt: fix compilation for enabled_protocols_model.


Summary of changes:
 ui/qt/models/enabled_protocols_model.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)