Wireshark · Wireshark-commits: [Wireshark-commits] master-2.6 45f6b40: What we're testing for is byte-swappedness, not raw endianne

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=45f6b400e2158ec11eb10fb45a6c2bb867def2c1
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

45f6b40 by Guy Harris (guy@xxxxxxxxxxxx):

    What we're testing for is byte-swappedness, not raw endianness.
    
    On a big-endian machine, if the upper 16 bits of the length are non-zero
    and the lower 16 bits are zero, that means that the length is
    *little*-endian.
    
    What we really care about is whether the file is in the reading host's
    native format, so we can just fetch integral values without swapping, or
    not in that format, in which case we have to byte-swap integral values.
    
    Rename the variable and redo the code to match.
    
    (This may have caused the PacketLogger reader to fail on big-endian
    machines.)
    
    Change-Id: Ie1a82a7d40e2c58c0b8d482d7c95ab60061ca980
    Ping-Bug: 10861
    Reviewed-on: https://code.wireshark.org/review/34434
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 45eadc049e5dce4d0181050f55a0d5709ac9c3c8)
    Reviewed-on: https://code.wireshark.org/review/34436
    

Actions performed:

    from  a3825d7   [Automatic update for 2019-09-01]
     add  45f6b40   What we're testing for is byte-swappedness, not raw endianness.


Summary of changes:
 wiretap/packetlogger.c | 31 ++++++++++++++-----------------
 1 file changed, 14 insertions(+), 17 deletions(-)