Wireshark-commits: [Wireshark-commits] master cdb9429: Strengthen the I4B heuristics.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 02 Sep 2019 21:40:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cdb942944aa91202fe85372c8f13c70db0ce3141
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

cdb9429 by Guy Harris (guy@xxxxxxxxxxxx):

    Strengthen the I4B heuristics.
    
    Check some more field values, and fix some tests to check against the
    maximum possible value given in the i4b_trace.h file rather than against
    that value + 1.  (> max, or >= max+1, are both reasonable, but > max+1
    isn't.)
    
    Check the first few packets, not just the first packet.
    
    Make some header fields unsigned, as that's how we treat them in most
    cases; that way we treat them that way by default.
    
    Change-Id: I8c2d28af048c676a3dbae367bbb49c886e0dc566
    Ping-Bug: 16031
    Reviewed-on: https://code.wireshark.org/review/34432
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  fc2260c   NAS 5GS: fix dissection of QoS flow description IE
     add  cdb9429   Strengthen the I4B heuristics.


Summary of changes:
 wiretap/i4b_trace.h |   6 ++--
 wiretap/i4btrace.c  | 102 +++++++++++++++++++++++++++++++++++++++++++---------
 2 files changed, 89 insertions(+), 19 deletions(-)