Wireshark-commits: [Wireshark-commits] master f402b4c: Qt: PacketList call DecodeAsDialog directly
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 02 Sep 2019 13:36:19 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f402b4cdaa72b02ac931165b908f41ec3740eeaa
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f402b4c by Roland Knall (rknall@xxxxxxxxx):

    Qt: PacketList call DecodeAsDialog directly
    
    Calling the directly from the context menu and setting data
    just before the execute of the menu can lead to information
    not present.
    
    Furthermore for future changes, the move to have QMenu only
    as a local variable is being reverted
    
    Change-Id: I470da26e658ae81ca416b3864889a4317b865755
    Reviewed-on: https://code.wireshark.org/review/34428
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  15a91a6   couchbase: update command identifiers
     add  f402b4c   Qt: PacketList call DecodeAsDialog directly


Summary of changes:
 ui/qt/packet_list.cpp | 71 ++++++++++++++++++++++++++++++---------------------
 ui/qt/packet_list.h   |  2 +-
 2 files changed, 43 insertions(+), 30 deletions(-)