Wireshark-commits: [Wireshark-commits] master 9ae6abd: Fix the section on Boolean fields to match r
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 01 Sep 2019 21:10:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9ae6abdec99d725d18633df66380067136a822b3
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9ae6abd by Guy Harris (guy@xxxxxxxxxxxx):

    Fix the section on Boolean fields to match reality.
    
    Confusing though it might be, a patch-matching expression containing
    only the name of a Boolean field matches all packets containing that
    field, regardless of whether the field is true or false; you need to
    compare the field against 1 to check whether it's true.
    
    Change-Id: I615acc4d71964c8474e6f3655ade8814cbe07b22
    Reviewed-on: https://code.wireshark.org/review/34422
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a53ec79   SMTP: Consider bytes seen as "data" until a command is seen
     add  9ae6abd   Fix the section on Boolean fields to match reality.


Summary of changes:
 docbook/wsug_src/WSUG_chapter_work.adoc | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)