Wireshark-commits: [Wireshark-commits] master b28952a: gryphon: General cleanup/improvements of dis
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 01 Sep 2019 09:02:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b28952afd401926849a03b9537d08a989284bc25
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b28952a by Michael Mann (mmann78@xxxxxxxxxxxx):

    gryphon: General cleanup/improvements of dissector
    
    1. Use switch statement for request/response functions
    2. Reorder functions to limit the need for forward declarations
    3. Use proto_tree_add_item_ret_uint and proto_tree_add_item_ret_length to
    limit "duplicate" functionality.
    4. Create initial (simple) request/response matching.  This can probably be
    improved upon.
    5. Use the request/response matching structures to pass (ioctl) context between
    request and response.
    
    Change-Id: I3f4c16c07f4b3aa9556d229d003a4842ff118cd9
    Reviewed-on: https://code.wireshark.org/review/34404
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e86880b   [Automatic update for 2019-09-01]
     add  b28952a   gryphon: General cleanup/improvements of dissector


Summary of changes:
 plugins/epan/gryphon/packet-gryphon.c | 1693 ++++++++++++++++++---------------
 plugins/epan/gryphon/packet-gryphon.h |   36 +-
 2 files changed, 943 insertions(+), 786 deletions(-)