Wireshark-commits: [Wireshark-commits] master 01d7793: Add proto_tree_add_item_ret_time_string
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=01d7793976cca50519c6609dc2a4ba391946f07b
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
01d7793 by Michael Mann (mmann78@xxxxxxxxxxxx):
Add proto_tree_add_item_ret_time_string
A few dissectors need the functionality of adding a time field to a proto_tree
while also needing the "time to string" value (typically to show on a tree above).
The functionality to do "get value from tvb and convert to string" was being done
in packet-ntp.c.
Instead proto_tree_add_item_ret_time_string can be used with various encoding to
get the necessary functionality with less code duplication.
ENC_TIME_MIP6 was added as a result of the refactoring.
ABSOLUTE_TIME_NTP_UTC was added as another potential "base" type for time fields.
Change-Id: Ie460c33370b0af59ef60bdab893ce9d6eb23b94f
Reviewed-on: https://code.wireshark.org/review/34390
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 862e2ac Qt: Extend filterbutton context menu
add 01d7793 Add proto_tree_add_item_ret_time_string
Summary of changes:
debian/libwireshark0.symbols | 1 +
epan/dissectors/asn1/m3ap/m3ap.cnf | 7 +-
epan/dissectors/asn1/m3ap/packet-m3ap-template.c | 3 +-
epan/dissectors/packet-diameter_3gpp.c | 7 +-
epan/dissectors/packet-gtpv2.c | 40 ++++----
epan/dissectors/packet-m3ap.c | 66 ++++++-------
epan/dissectors/packet-mip6.c | 7 +-
epan/dissectors/packet-ntp.c | 99 +-------------------
epan/dissectors/packet-ntp.h | 2 -
epan/dissectors/packet-pfcp.c | 64 ++++++-------
epan/dissectors/packet-rtcp.c | 9 +-
epan/proto.c | 113 ++++++++++++++++++++++-
epan/proto.h | 24 ++++-
epan/time_fmt.h | 3 +-
epan/to_str.c | 14 +++
15 files changed, 237 insertions(+), 222 deletions(-)
