Wireshark-commits: [Wireshark-commits] master-3.0 2ef0828: DCERPC: workaround that pidl always emit
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 29 Aug 2019 02:30:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ef082803a03a5b84ad190b8dbef011edbf5bab6
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

2ef0828 by Ralph Boehme (slow@xxxxxxxxx):

    DCERPC: workaround that pidl always emits dissect_deferred_pointers()
    
    Commit f57cf9e56c90c0c0c724f415eff35821afaaf849 introduced a DISSECTOR_ASSERT()
    that revealed a deficiency in pidl: currently pidl unconditionally adds calls to
    dissect_deferred_pointers() which breaks dissecting any RPC function that
    has only scalar arguments:
    
      Warn Dissector bug, protocol RPCMDSSVC, in packet 51:
      epan/dissectors/packet-dcerpc.c:2940:
      failed assertion "list_ndr_pointer_list"
    
    Bug: 16022
    Change-Id: I9d3522a3e17ef79b9a8a5acb018104ab398a512a
    Reviewed-on: https://code.wireshark.org/review/34364
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit c9f2b9b3edcc7d99a0eb9b506ff3b5f0101bd1a8)
    Reviewed-on: https://code.wireshark.org/review/34391
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  91e37ba   NFS: Fix hash table key memory corruption
     add  2ef0828   DCERPC: workaround that pidl always emits dissect_deferred_pointers()


Summary of changes:
 epan/dissectors/packet-dcerpc.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)