Wireshark · Wireshark-commits: [Wireshark-commits] master 5f5a934: Use g_hash_table_replace() when key depends on data

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f5a934bca72f352f64bc5138c58cbc3dbea8323
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5f5a934 by Tomasz Moń (desowin@xxxxxxxxx):

    Use g_hash_table_replace() when key depends on data
    
    Using g_hash_table_insert() in cases where the key is contained within
    value is error prone. Use g_hash_table_replace() to eliminate the risk
    of ending up with incoherent hash table state.
    
    Change-Id: I595457476a2682e927d2c56b2692404aef4dc43a
    Reviewed-on: https://code.wireshark.org/review/34385
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  05b6a9a   Kafka: fixed OffsetForLeaderEpoch dissection
     add  5f5a934   Use g_hash_table_replace() when key depends on data


Summary of changes:
 epan/stats_tree.c | 2 +-
 wsutil/plugins.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)