Wireshark-commits: [Wireshark-commits] master 6981265: SMTP: Add support for multiline responses
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Aug 2019 04:04:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=698126581eebdd757d2e55830370b8dd3d9b759d
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6981265 by Michael Mann (mmann78@xxxxxxxxxxxx):

    SMTP: Add support for multiline responses
    
    Commands with "-" at the end mean another line with the same command will
    follow.  Group all of those lines in a single response tree and don't append
    the command value in the Info column for the additional lines.
    
    Bug: 15933
    Change-Id: Icba167f2f1d22ebaf53a6844285ba83ed8a20106
    Reviewed-on: https://code.wireshark.org/review/34381
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c9f2b9b   DCERPC: workaround that pidl always emits dissect_deferred_pointers()
     add  6981265   SMTP: Add support for multiline responses


Summary of changes:
 epan/dissectors/packet-smtp.c | 75 ++++++++++++++++++++++++++++++-------------
 1 file changed, 53 insertions(+), 22 deletions(-)