Wireshark-commits: [Wireshark-commits] master 3870e6c: Qt: Make Apply/Prepare filter independent
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 26 Aug 2019 19:39:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3870e6c0365d90f53c89a3fb5537f1b9a4d6218e
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3870e6c by Roland Knall (rknall@xxxxxxxxx):

    Qt: Make Apply/Prepare filter independent
    
    The context menu should only use information readily available
    at the point of creation. Copying actions from the mainwindow
    introduces a bunch of synchronization and consistency issues.
    
    This is a first step to move away from a centralized approach
    of managing actions, towards a distributed approach. As a side
    effect, this also solves the old issue of having the apply
    items greyed out in context menu
    
    Bug: 16001
    Bug: 15323
    Change-Id: I10c6df11cbab0a89386f5bf1d27759103df2a012
    Reviewed-on: https://code.wireshark.org/review/34370
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  a7838d9   coap: Distinguish observe option for request and response
     add  3870e6c   Qt: Make Apply/Prepare filter independent


Summary of changes:
 ui/qt/filter_action.cpp     | 52 +++++++++++++++++++++++++++++++++++++++++++++
 ui/qt/filter_action.h       |  8 +++++++
 ui/qt/main_window.h         |  1 +
 ui/qt/main_window_slots.cpp |  7 +++++-
 ui/qt/proto_tree.cpp        | 38 +++++++++++++++------------------
 5 files changed, 84 insertions(+), 22 deletions(-)