Wireshark-commits: [Wireshark-commits] master 8e92523: Modbus: Unit and Transaction Id for request/
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 24 Aug 2019 06:36:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8e925238b09b48c773f1d0877ada8c30fc861ce7
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8e92523 by Thomas Wiens (th.wiens@xxxxxx):

    Modbus: Unit and Transaction Id for request/response identification
    
    Use Unit and Transaction Identifier to identify the correct request to a
    response.
    The Transaction Identifier is only available in Modbus TCP.
    
    Bug: 15698
    Change-Id: Ic3a279ce200bee9e9274aaec66bd9dc2f1c096b9
    Reviewed-on: https://code.wireshark.org/review/34274
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3f22907   mpeg(dsmcc): Fixed range values
     add  8e92523   Modbus: Unit and Transaction Id for request/response identification


Summary of changes:
 epan/dissectors/packet-cip.c   | 14 ++++++++---
 epan/dissectors/packet-ecmp.c  | 14 +++++++----
 epan/dissectors/packet-mbtcp.c | 57 ++++++++++++++++++++++++++++--------------
 epan/dissectors/packet-mbtcp.h |  8 ++++++
 4 files changed, 65 insertions(+), 28 deletions(-)