Wireshark-commits: [Wireshark-commits] master 845bbb9: BLIP: Fix issues with message decompression
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 23 Aug 2019 08:41:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=845bbb9d9f055ceeb112c7e2911c0d5217a5800f
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

845bbb9 by Jim Borden (jim.borden@xxxxxxxxxxxxx):

    BLIP: Fix issues with message decompression
    
    Due to the way the BLIP compresses its messages, it quickly falls apart
    when the messages are not examined exactly in order (as is the case
    when selecting random frames inside of a capture).  The only solution
    I can see is to only decompress once and store the result somewhere
    that is persistent at the file level.
    
    Change-Id: I38c781222c8efbbcded2446ae02fa7cb57c71509
    Reviewed-on: https://code.wireshark.org/review/33827
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a6eb73a   Pegasus LSC: Added Status Codes
     add  845bbb9   BLIP: Fix issues with message decompression


Summary of changes:
 epan/dissectors/packet-blip.c | 109 ++++++++++++++++++++++++++----------------
 1 file changed, 67 insertions(+), 42 deletions(-)