Wireshark-commits: [Wireshark-commits] master 8b8ce52: SCTP: Make association amalysis a prference
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 20 Aug 2019 13:12:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8b8ce52abcf98f44bea025809c75f22224825ecb
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8b8ce52 by Anders Broman (anders.broman@xxxxxxxxxxxx):

    SCTP: Make association amalysis a prference defaulting to FALSE.
    
    Association analysis causes long loops if there is a lot off
    associations or IMIT ABORTS. On a 679K packets trace loading with
    amalysis takes 3.31.660 without 0.3.275. The culprit is the for loop
    in find_assoc_index().
    
    Change-Id: I07ae0e826c08aded3eb0e7dc3474dcf5cdd556f9
    Reviewed-on: https://code.wireshark.org/review/34333
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  6cf81c5   Kafka: fix the name shadowing
     add  8b8ce52   SCTP: Make association amalysis a prference defaulting to FALSE.


Summary of changes:
 epan/dissectors/packet-sctp.c | 75 +++++++++++++++++++++++++------------------
 1 file changed, 43 insertions(+), 32 deletions(-)