Wireshark · Wireshark-commits: [Wireshark-commits] master 4278234: USBLL: Use custom address dissector instead of usb one

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4278234a1db0d98247f2062a879f78cc9d741d6d
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4278234 by Krzysztof Opasiak (k.opasiak@xxxxxxxxxxx):

    USBLL: Use custom address dissector instead of usb one
    
    Usage of USB address dissector creates several challenges. In order to
    improve user experience let's create a custom address dissector.
    This allows us to not only drop the busid parameter but also replace
    endpoint parameter with hub port for SPLIT transactions.
    
    The address may be one of 3 forms:
    - host
    - <device address>.<endpoint>
    - <hub address>:<hub port> (for SPLIT transactions)
    
    This also adds 3 new fields (source, destination and addr) with
    exactly the same meaning as in usb. It also renames current addr field
    to device_addr.
    
    Strongly based on initial work by:
          Maciej Purski <maciej.purski@xxxxxxxxx>
    
    Ping-Bug: 15908
    Change-Id: I5702295d7ef9076c3e0373de35ea4ac3cb2a0709
    Signed-off-by: Krzysztof Opasiak <k.opasiak@xxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/34279
    Reviewed-by: Tomasz Moń <desowin@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d8385b4   MB-34017: Add HCS to SnapshotMarker
     add  4278234   USBLL: Use custom address dissector instead of usb one


Summary of changes:
 epan/dissectors/packet-usbll.c | 167 +++++++++++++++++++++++++++++++++++------
 1 file changed, 142 insertions(+), 25 deletions(-)