Wireshark · Wireshark-commits: [Wireshark-commits] master 83220ac: Revert "TLS: allow dissectors to set the appdata protocol via th

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=83220acb484e1ae615602c57c4f4eafaecbf4a5d
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

83220ac by Peter Wu (peter@xxxxxxxxxxxxx):

    Revert "TLS: allow dissectors to set the appdata protocol via the data param"
    
    This reverts commit ede7be3440689cee51489361934704467f2b2ffb.
    
    The TLS dissector can be called via multiple entrypoints. It could be
    called directly (the EAP-TTLS/EAP-PEAP case with an explicit dissector
    name), but also through dissector tables. The TCP and SCTP dissectors
    however pass a data parameter of a different type, resulting in crashes
    due to type confusion.
    
    Change-Id: I1d21cb5e31eb09689970ff3bdc7a63c6b7965d49
    Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=16442
    Link: https://www.wireshark.org/lists/wireshark-dev/201908/msg00037.html
    Reviewed-on: https://code.wireshark.org/review/34310
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  41b8c22   Windows: add nghttp2.pdb file to our PDB .zip
     add  83220ac   Revert "TLS: allow dissectors to set the appdata protocol via the data param"


Summary of changes:
 epan/dissectors/packet-tls.c | 20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)