Wireshark-commits: [Wireshark-commits] master a537edf: Diameter: Add MS-CHAP/MS-CHAPv2 AVP support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 15 Aug 2019 04:10:24 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a537edfdfff3be7366ae691e6e5403b1972322bf
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a537edf by Peter Wu (peter@xxxxxxxxxxxxx):

    Diameter: Add MS-CHAP/MS-CHAPv2 AVP support for EAP-TLS
    
    Created the Microsoft Diameter file based on MS-CHAP-* AVPs listed at
    https://www.iana.org/assignments/eap-numbers/eap-numbers.xhtml#eap-numbers-10
    Many values are displayed as bytes for simplicit. The MS-CHAP2-Success
    attribute could for example be dissected further as 1 byte followed by a
    string, but that requires more effort.
    
    Allow padding to be missing since the eap-ttls-mschapv2.pcapng capture
    would throw a Malformed Packet exception otherwise.
    
    Bug: 15603
    Change-Id: I9efc322a86802e78bb6cd4bc3df1c1282a45fe9e
    Reviewed-on: https://code.wireshark.org/review/34291
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4a795a4   EAP: add support for EAP-PEAP
     add  a537edf   Diameter: Add MS-CHAP/MS-CHAPv2 AVP support for EAP-TLS


Summary of changes:
 diameter/Microsoft.xml            | 32 ++++++++++++++++++++++++++++++++
 diameter/dictionary.xml           |  2 ++
 epan/dissectors/packet-diameter.c | 12 ++++++++++++
 packaging/nsis/wireshark.nsi      |  1 +
 4 files changed, 47 insertions(+)
 create mode 100644 diameter/Microsoft.xml