Wireshark · Wireshark-commits: [Wireshark-commits] master f05efc5: EAP, Diameter: add EAP-TTLS and EAP-Message dissection support

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f05efc56635da34f5deea85fa0200c0f377f2a5d
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f05efc5 by Peter Wu (peter@xxxxxxxxxxxxx):

    EAP, Diameter: add EAP-TTLS and EAP-Message dissection support
    
    Add support for dissecting the decrypted TLS payload as Diameter.
    Add support for dissecting the EAP-Message attribute as EAP.
    Disable retransmission detection when EAP-Message is detected (EAP in
    TLS in EAP) since this results in false positives.
    
    Tested with captures from Bug 15603:
    
    * eap-ttls-pap.pcapng - ok, User-Name and User-Password AVPs.
    * eap-ttls-eap-gtc.pcapng, eap-ttls-eap-md5.pcapng - EAP-Message AVP.
    * eap-ttls-mschapv2.pcapng - partially supported, does not conform to
      Diameter AVP requirements as it is not padded. Microsoft vendor types
      are also not yet supported. To be fixed later.
    * eapttls-diameter-avp.pcapng (Bug 12880) - EAP-Message AVP.
    
    Bug: 12880
    Bug: 15603
    Change-Id: Ie7ea282d05c1d3ff8463c34bf259107562714440
    Reviewed-on: https://code.wireshark.org/review/34281
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ede7be3   TLS: allow dissectors to set the appdata protocol via the data param
     add  f05efc5   EAP, Diameter: add EAP-TTLS and EAP-Message dissection support


Summary of changes:
 epan/dissectors/packet-diameter.c |  42 ++++++++++++-
 epan/dissectors/packet-eap.c      | 127 +++++++++++++++++++++++---------------
 2 files changed, 116 insertions(+), 53 deletions(-)