Wireshark-commits: [Wireshark-commits] master c4b68b4: Wiretap: Fix temporary filename memory corru
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Aug 2019 20:33:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c4b68b4935081f291795d60a91518a98b6ba9d0d
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c4b68b4 by Tomasz Moń (desowin@xxxxxxxxx):

    Wiretap: Fix temporary filename memory corruption
    
    The pointer returned by create_tempfile() must not be freed. As the
    wtap_dump_open_tempfile() callers are freeing the returned filename,
    duplicate the string so it can be freed.
    
    Bug: 15377
    Change-Id: Ib0b23aaee748ef67600ef3f7d40610ebbbec721c
    Reviewed-on: https://code.wireshark.org/review/34272
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  81d2de9   Try to fix Wpointer-sign warnings.
     add  c4b68b4   Wiretap: Fix temporary filename memory corruption


Summary of changes:
 file.c                       | 4 ++--
 file.h                       | 2 +-
 ui/qt/import_text_dialog.cpp | 1 +
 ui/qt/main_window.cpp        | 5 ++---
 wiretap/file_access.c        | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)