Wireshark-commits: [Wireshark-commits] master 4b00898: Qt: Prevent loop in renames of profiles
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Aug 2019 08:16:19 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4b00898a2a3f84cd442389439fbbc77fba52a10e
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4b00898 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Prevent loop in renames of profiles
    
    This prevents the case, where there are two profiles, and one is
    renamed, after which the second one is renamed to the firsts original
    name. This could lead to undefined behavior in the underlying data
    structure.
    
    Fixes an issue as well, where deleting the identical named duplicate
    would delete the original one
    
    Bug: 15975
    Change-Id: Ia7112779f2c2ef926c3ea915852b6d7b4497f777
    Reviewed-on: https://code.wireshark.org/review/34189
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  7daf939   Qt: Fix translations for profiles
     add  4b00898   Qt: Prevent loop in renames of profiles


Summary of changes:
 ui/profile.c                   |  23 +++--
 ui/profile.h                   |   4 +-
 ui/qt/models/profile_model.cpp | 228 +++++++++++++++++++++++++++++++++--------
 ui/qt/models/profile_model.h   |   6 ++
 ui/qt/profile_dialog.cpp       |  33 ++++--
 5 files changed, 233 insertions(+), 61 deletions(-)