Wireshark-commits: [Wireshark-commits] master 478b39e: ZigBee OTA: Fix field-control dissection in
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Aug 2019 04:33:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=478b39e82457475670fc6a1e6f593b80db39776d
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

478b39e by Martin Boye Petersen (martinboyepetersen@xxxxxxxxx):

    ZigBee OTA: Fix field-control dissection in OTA commands
    
    Field control field was handled in the same way for QueryNextImageRequest,
    ImageBlockRequest and ImagePageRequest, but none of these fields
    are defined in the same way according to the specification.
    Also the optional MinimumBlockPeriod field in ImageBlockRequest was missing.
    
    Change-Id: Ibd5c7adbcc6493771baf0a099661cbd2282ee71d
    Reviewed-on: https://code.wireshark.org/review/34257
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  6ab745c   nfs: Add the third version of the Hammerspace NFSv4 file handle dissector
     add  478b39e   ZigBee OTA: Fix field-control dissection in OTA commands


Summary of changes:
 epan/dissectors/packet-zbee-zcl-general.c | 152 ++++++++++++++++++++++--------
 1 file changed, 111 insertions(+), 41 deletions(-)