Wireshark-commits: [Wireshark-commits] master dc4084f: Qt: Respect recent values on startup
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 08 Aug 2019 11:13:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dc4084fb822e4669aac95a6dc8c0b6b36597e9bd
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

dc4084f by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Respect recent values on startup
    
    Do not call showHideMainWidgets() in initShowHideMainWidgets() because
    this will override loaded recent values on startup.
    
    Setting checked and visible based on recent values is done in layoutPanes()
    and updateRecentActions().
    
    This affects the following View settings: Main Toolbar, Filter Toolbar,
    Wireless Toolbar, Status Bar, Packet List, Packet Details and Packet Bytes.
    
    Also always hide empty_pane because it's never useful to show this.
    
    Bug: 15976
    Change-Id: Id63b8a5fdd263793a283137134f424d7cb4caf82
    Reviewed-on: https://code.wireshark.org/review/34209
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  52e111e   Qt: Remove unnecessary label from default copy
     add  dc4084f   Qt: Respect recent values on startup


Summary of changes:
 ui/qt/main_window.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)