Wireshark-commits: [Wireshark-commits] master f259187: Qt: Update UI for profiles and handle export
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 02 Aug 2019 21:38:09 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f2591878034f5380de4cef5ed9532942ea16469c
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f259187 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Update UI for profiles and handle export/import properly
    
    This patchset ensures a 1:1 replacement of the old 3.0 version of the profiles
    dialog. It is a major bugfix for the new version in case of handling creating/
    deleting and adding profiles.
    
    Delete can be performed on multiple profiles now, by selecting the profiles
    which need to be deleted.
    
    Import/Export functionality has been overhauled to follow these rules:
    
    * No imports while changes are pending, due to datamodel sanity
    * Export for Default Profile and Global Profiles is not possible
    * Either all personal profiles can be selected or individually choosen ones
    * Use last directory and store it properly
    * Imports can be cancelled
    * Only one import is allowed at a time (but it can contain as many profiles as needed)
    
    Change-Id: Ie2fccd397202ec06976d764734437284f464409a
    Reviewed-on: https://code.wireshark.org/review/34123
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  66747a9   wsutil: link with -lm.
     add  f259187   Qt: Update UI for profiles and handle export/import properly


Summary of changes:
 docbook/wsug_graphics/ws-gui-config-profiles.png | Bin 5027 -> 120304 bytes
 docbook/wsug_src/WSUG_chapter_customize.adoc     |  24 +-
 ui/profile.h                                     |   1 +
 ui/qt/main_status_bar.cpp                        |  59 ++--
 ui/qt/models/profile_model.cpp                   | 318 ++++++++++++++----
 ui/qt/models/profile_model.h                     |  46 ++-
 ui/qt/profile_dialog.cpp                         | 401 ++++++++++++++++++-----
 ui/qt/profile_dialog.h                           |  14 +-
 ui/qt/profile_dialog.ui                          |   5 +-
 ui/qt/widgets/profile_tree_view.cpp              |  60 ++--
 ui/qt/widgets/profile_tree_view.h                |  14 +-
 ui/qt/wireshark_en.ts                            |  21 ++
 12 files changed, 737 insertions(+), 226 deletions(-)