Wireshark-commits: [Wireshark-commits] master a0cdb06: Fix shadow variable warnings, fix type error
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 30 Jul 2019 07:47:25 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a0cdb06abafc596d84baa0c8a14b2971c88ce661
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a0cdb06 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix shadow variable warnings, fix type error.
    
    Sadly, index() is still defined to be a function in some UN*Xes, for
    backwards compatibility with V7, where the function now known as
    strchr() was called index(); pick another name for variables named
    "index".
    
    wmem_array_get_count() returns a guint; store its value in a guint.
    That also means its return value is never negative.
    
    Change-Id: I357dcda9297f242355ef1ad8d2f1f192a0b5bb5f
    Reviewed-on: https://code.wireshark.org/review/34132
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  679ae4c   Qt: Improve numerus translation in status bar
     add  a0cdb06   Fix shadow variable warnings, fix type error.


Summary of changes:
 epan/tvbuff_lz77huff.c | 38 ++++++++++++++++++--------------------
 1 file changed, 18 insertions(+), 20 deletions(-)