Wireshark-commits: [Wireshark-commits] master 99f574a: Initialize newly-allocated iap_conversation_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 26 Jul 2019 10:23:39 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=99f574aecb0115e5017fb120056117220ffed87b
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

99f574a by Guy Harris (guy@xxxxxxxxxxxx):

    Initialize newly-allocated iap_conversation_t before fetching packet data.
    
    If we do it after trying to fetch packet data, the attempt to fetch
    might throw an exception, and the structure won't be fully initialized.
    
    Bug: 15934
    Change-Id: If50a8c18232d934c1e33512cddb40a011a4eaef7
    Reviewed-on: https://code.wireshark.org/review/34087
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  3a137df   Debian: remove symbols
     add  99f574a   Initialize newly-allocated iap_conversation_t before fetching packet data.


Summary of changes:
 plugins/epan/irda/packet-irda.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)