Wireshark-commits: [Wireshark-commits] master 3e01632: Use g_ascii_isalpha(), not is_rfc2234_alpha(
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 24 Jul 2019 20:38:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3e01632a684b5c4d1c7026929cbba6d664e56c84
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3e01632 by Guy Harris (guy@xxxxxxxxxxxx):

    Use g_ascii_isalpha(), not is_rfc2234_alpha().
    
    Use GLib's locale-independent "is this alphabetic?" routine, rather than
    rolling our own.
    
    Change-Id: I841de09d534867ec7510bd680fd97387719b2850
    Reviewed-on: https://code.wireshark.org/review/34075
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  4b336ce   Use tvb_get_raw_bytes_as_string() to fetch the reply code.
     add  3e01632   Use g_ascii_isalpha(), not is_rfc2234_alpha().


Summary of changes:
 epan/dissectors/packet-mgcp.c | 25 +++----------------------
 1 file changed, 3 insertions(+), 22 deletions(-)