Wireshark-commits: [Wireshark-commits] master 4e9ce8e: Handle multiple PDUs per TCP segment and rea
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 24 Jul 2019 19:42:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4e9ce8e4b3679fbc91ecb2ad2cc84b92570dfedb
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4e9ce8e by Guy Harris (guy@xxxxxxxxxxxx):

    Handle multiple PDUs per TCP segment and reassembly of multi-segment PDUs.
    
    Use tcp_dissect_pdus().
    
    Put the packet length and packet type into the protocol tree as items.
    
    Pass to routines dissecting various packet types an offset to the data
    past the packet type indication.
    
    While we're at it:
    
    Clear the Info column, so it doesn't contain TCP-level stuff.
    
    Use the new tvb_get_raw_bytes_as_string() to get the first 4 bytes of
    the payload as a string.
    
    Fix the capitalization of some field names.
    
    Change-Id: I3d5b8f4b4115d7b3675fbebc68a5e67976aba27b
    Reviewed-on: https://code.wireshark.org/review/34073
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  2c7e0a9   Add a routine to fetch raw bytes into a fixed-length buffer as a string.
     add  4e9ce8e   Handle multiple PDUs per TCP segment and reassembly of multi-segment PDUs.


Summary of changes:
 epan/dissectors/packet-synergy.c | 281 +++++++++++++++++++++++----------------
 1 file changed, 167 insertions(+), 114 deletions(-)