Wireshark-commits: [Wireshark-commits] master c557809: Clean up handling of group lists.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 24 Jul 2019 17:21:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c55780951cfd44420d1a40d5e6d68ee20af98338
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c557809 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up handling of group lists.
    
    Use a wmem_strbuf_t for the group list, so it expands as necessary,
    rather than a static string buffer.  Pass it to dissect_group() through
    dissect_rpc_list().
    
    For each group, get the group name from the call to
    dissect_rpc_string(), and append it to the wmem_strbuf_t.
    
    Change-Id: I65b36a9b6d34dd1e88babd005fc60ab46331b382
    Reviewed-on: https://code.wireshark.org/review/34069
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  53fddee   Remove an extra backslash.
     add  c557809   Clean up handling of group lists.


Summary of changes:
 epan/dissectors/packet-mount.c | 44 +++++++++++++++++-------------------------
 1 file changed, 18 insertions(+), 26 deletions(-)