Wireshark-commits: [Wireshark-commits] master 4257a84: Qt: Improve profile import messages
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Jul 2019 21:07:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4257a8486de39a71b7b6d7869301ece5be0b3cfe
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4257a84 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Improve profile import messages
    
    Only show the message "No profiles found for import" when no profiles
    actually found, not when found but all are skipped.
    
    Add correct numerus translation for imported and skipped counts.
    
    Change-Id: I0425aafb09fc4722cc765ae4f20ce8248b767c44
    Reviewed-on: https://code.wireshark.org/review/34050
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  193ca63   Qt: Fix deletion
     add  4257a84   Qt: Improve profile import messages


Summary of changes:
 ui/qt/models/profile_model.cpp |  5 -----
 ui/qt/profile_dialog.cpp       | 40 ++++++++++++++++++++++++++++------------
 ui/qt/wireshark_en.ts          | 16 +++++++++++++---
 3 files changed, 41 insertions(+), 20 deletions(-)